Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsplit wheel builds now that we have an index #101410

Closed
wants to merge 5 commits into from
Closed

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 4, 2023

Proposed change

We should not hit the memory limit anymore now that we have an index.

However since memory usage is not always exactly the same, and other changes will affect it, there may still be a specific wheel that needs the split though, but we can't tell for sure until it actually happens.

If it turns out we still are hitting the limit in the future, we can revert (or switch to a 2 part split) this PR when/if that happens.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We should not hit the memory limit anymore now that we have
an index
@home-assistant home-assistant bot added cla-signed Hacktoberfest small-pr PRs with less than 30 lines. labels Oct 4, 2023
@bdraco
Copy link
Member Author

bdraco commented Oct 5, 2023

This was successful but we are still building wheels we probably shouldn't be

https://github.com/home-assistant/core/actions/runs/6413564741/job/17412686181

I'm not sure pip is the latest version on the wheel builder

@bdraco
Copy link
Member Author

bdraco commented Oct 6, 2023

needs to be retested once #100646 (comment) is sorted

@bdraco
Copy link
Member Author

bdraco commented Oct 6, 2023

split build times
https://github.com/home-assistant/core/actions/runs/6436986686

unsplit build times
https://github.com/home-assistant/core/actions/runs/6436993424

@frenck
Copy link
Member

frenck commented Oct 7, 2023

Let's remove the splitting 👍

Happy to see that workaround go away

@bdraco
Copy link
Member Author

bdraco commented Oct 7, 2023

The split is sometimes faster which is likely because of pip getting slower with a higher number of packages pypa/pip#12314

I've been sitting on this one because I wanted to see the outcome of the above issue as it might make sense to keep them split until that gets solved

@frenck
Copy link
Member

frenck commented Nov 23, 2023

Going to close this for now, until things get resolved upstream.

Cleaning up the queues a bit, to gain a better overview of our open PR queue.

../Frenck

@frenck frenck closed this Nov 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
@bdraco bdraco deleted the unsplit_wheels branch February 8, 2024 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants