-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsplit wheel builds now that we have an index #101410
Conversation
We should not hit the memory limit anymore now that we have an index
This was successful but we are still building wheels we probably shouldn't be https://github.com/home-assistant/core/actions/runs/6413564741/job/17412686181 I'm not sure pip is the latest version on the wheel builder |
needs to be retested once #100646 (comment) is sorted |
split build times unsplit build times |
Let's remove the splitting 👍 Happy to see that workaround go away |
The split is sometimes faster which is likely because of pip getting slower with a higher number of packages pypa/pip#12314 I've been sitting on this one because I wanted to see the outcome of the above issue as it might make sense to keep them split until that gets solved |
Going to close this for now, until things get resolved upstream. Cleaning up the queues a bit, to gain a better overview of our open PR queue. ../Frenck |
Proposed change
We should not hit the memory limit anymore now that we have an index.
However since memory usage is not always exactly the same, and other changes will affect it, there may still be a specific wheel that needs the split though, but we can't tell for sure until it actually happens.
If it turns out we still are hitting the limit in the future, we can revert (or switch to a 2 part split) this PR when/if that happens.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: