Fix mqtt light rgbww update without state topic #100707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix mqtt light rgbww update without state topic.
When an rgbww update is received
color_util.color_rgbww_to_rgb
is called in_rgbx_received
and without the brightness state topic passing the color value missing 2 positional attributesmin_kelvin
andmax_kelvin
.This PR fixes this condition and add a test updating
_attr_color_mode
_attr_brighness
and_attr_rgb_color
,_attr_rgbw_color
and_attr_rgbww_color
when a rgbx color update message is received.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: