Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missspelled package names #100670

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix missspelled package names #100670

merged 1 commit into from
Sep 21, 2023

Conversation

edenhaus
Copy link
Contributor

Breaking change

Proposed change

Runned pypi-package-name (from #100646) on the project and fixed the following packages:

vscode ➜ /workspaces/core (pip-name-checker) $ python -m script.pypi_name_validator --mode all
The following requirements should be renamed to match Pypi's name:
* "aiohttp-cors" to "aiohttp_cors"
* "asterisk-mbox" to "asterisk_mbox"
* "async_interrupt" to "async-interrupt"
* "foobot-async" to "foobot_async"
* "gardena_bluetooth" to "gardena-bluetooth"
* "greeneye-monitor" to "greeneye_monitor"
* "pushover-complete" to "pushover_complete"
* "pyduotecno" to "pyDuotecno"
* "requests_mock" to "requests-mock"
* "sharp-aquos-rc" to "sharp_aquos_rc"
* "tplink_omada_client" to "tplink-omada-client"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Sep 21, 2023
@edenhaus edenhaus changed the title Use correct package names Use correct missspelled package names Sep 21, 2023
@edenhaus edenhaus changed the title Use correct missspelled package names Fix missspelled package names Sep 21, 2023
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for gardena

@frenck frenck merged commit e4742c0 into dev Sep 21, 2023
31 checks passed
@frenck frenck deleted the edenhaus-fix-package-names branch September 21, 2023 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants