-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Comelit device info #100587
Fix Comelit device info #100587
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Please add more explanation in the PR description. What is this fixing? |
Done, let me know if is clear enough. |
Is this not a case of a device with multiple endpoints that is described in the last paragraph of the following section? https://developers.home-assistant.io/docs/device_registry_index#what-is-a-device |
Seems so, but as the main device has no entities, how can I refer to it with |
It's possible to register a device directly with core/homeassistant/helpers/device_registry.py Lines 475 to 497 in 33f7484
|
bf4c556
to
137ef98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chemelli74 👍
../Frenck
Breaking change
Proposed change
Fix Comelit device info in order to create a single device as Lights and covers are connected to the bridge via proprietary bus and all peripherals ( lights, covers, etc) can be controlled only via bridge and not directly.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: