Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing vacuum entity for Q Revo #96779

Closed
hoffbaked opened this issue Jul 17, 2023 · 15 comments
Closed

Missing vacuum entity for Q Revo #96779

hoffbaked opened this issue Jul 17, 2023 · 15 comments

Comments

@hoffbaked
Copy link

The problem

We added a Q Revo to our house in addition to the S7 we had previously. All the sensor, select, and switch entities appear for the Q Revo, but the vacuum.roborock_q_revo entity is not there. I was attempting to get the room mappings, but I can't send the vacuum any commands without the vacuum entity.

What version of Home Assistant Core has the issue?

core-2023.7.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roborock

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roborock/

Diagnostics information

config_entry-roborock-10feebba66a9d06e77d4db23f3a0e8d7.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

There is this log entry, that was noted in another bug:

Logger: roborock.code_mappings
Source: runner.py:179 
First occurred: July 16, 2023 at 8:23:30 AM (3064 occurrences) 
Last logged: 9:54:39 AM

Missing RoborockDockTypeCode code: 8 - defaulting to 'unknown'

Additional information

No response

@home-assistant
Copy link

Hey there @humbertogontijo, @Lash-L, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


roborock documentation
roborock source
(message by IssueLinks)

@Lash-L
Copy link
Contributor

Lash-L commented Jul 17, 2023

So every entity except the vacuum shows up? Can you turn on debug logging and restart your HA instance?

@hoffbaked
Copy link
Author

hoffbaked commented Jul 17, 2023 via email

@moranbf
Copy link

moranbf commented Jul 17, 2023

This looks like the same issue I am having, except this is the first Roborock device for me:

#96757 (comment)

@moranbf
Copy link

moranbf commented Jul 17, 2023

I loaded HA and still get the same error:
Logger: roborock.code_mappings
Source: runner.py:179
First occurred: 4:17:09 PM (8 occurrences)
Last logged: 4:20:16 PM

Missing RoborockDockTypeCode code: 8 - defaulting to 'unknown'

@Lash-L
Copy link
Contributor

Lash-L commented Jul 17, 2023

@moranbf is your vacuum entity working? That error doesn't really matter but that will be fixed

@chasebolt
Copy link

i also came here because i have no vacuum entity. i have a q revo and a s6. all the sensor data has entities but not the vacuums themselves.

@Lash-L
Copy link
Contributor

Lash-L commented Jul 17, 2023

i also came here because i have no vacuum entity. i have a q revo and a s6. all the sensor data has entities but not the vacuums themselves.

Have you restarted your home assistant insurance? Can you enable debug logging and send me your logs

@chasebolt
Copy link

Source: components/roborock/vacuum.py:96
First occurred: 3:48:58 PM (1 occurrences)
Last logged: 3:48:58 PM

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 490, in async_add_entities
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 490, in <listcomp>
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 63, in <genexpr>
    RoborockVacuum(slugify(device_id), coordinator)
  File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 96, in __init__
    self._attr_fan_speed_list = self._device_status.fan_power.keys()
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'keys'

retrieved this from the log when reloading the integration

@Lash-L
Copy link
Contributor

Lash-L commented Jul 17, 2023


Source: components/roborock/vacuum.py:96

First occurred: 3:48:58 PM (1 occurrences)

Last logged: 3:48:58 PM



Error doing job: Task exception was never retrieved

Traceback (most recent call last):

  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 490, in async_add_entities

    tasks = [

            ^

  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 490, in <listcomp>

    tasks = [

            ^

  File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 63, in <genexpr>

    RoborockVacuum(slugify(device_id), coordinator)

  File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 96, in __init__

    self._attr_fan_speed_list = self._device_status.fan_power.keys()

                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

AttributeError: 'NoneType' object has no attribute 'keys'

retrieved this from the log when reloading the integration

I need your debug logs as well. I need to know what the result of get_status is as I can't tell why it is being set to None I'm pretty sure I know but I need more data.

Or your diagnostic data if it will work

@chasebolt
Copy link

ok i did a reboot of HA and everything is there. wish i had dumped the debug logs prior for you, but since you asked for a reboot first i did that. guess this bug will live in the ether until the next soul that comes across it! 😆

i went from 2 devices & 18 entities to 2 devices & 24 entities.

@moranbf
Copy link

moranbf commented Jul 18, 2023

I was collecting logs and think I have resolved my issue. I had my vac on an isolated IOT network and found out it that the vac talks directly to HA. I few firewall rules later. It looks like it is working. Thanks for letting me know about the dock error being a red herring.

2023-07-17 20:47:33.595 DEBUG (MainThread) [roborock.cloud_api] id=blah Response from get_network_info: {'ssid': 'sandstorm', 'ip': '192.168.101.114', 'mac': 'blah5', 'bssid': 'blah', 'rssi': -46}

A few firewall rules later, I now have an entity for the vac, and it appears to work as I was able to send it to clean, and tell it to return to the doc successfully.

image

@SaSa1983
Copy link
Contributor

I own a Q Revo and the vacuum entity is there

@Lash-L
Copy link
Contributor

Lash-L commented Sep 23, 2023

Closing this issue as it appears it be resolved for everyone

@Lash-L
Copy link
Contributor

Lash-L commented Sep 23, 2023

@home-assistant close

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants