Avoid tracking tasks that finish right away (#111690)

home-assistant · Feb 28, 2024 · b9718fe · b9718fe
1 parent 470d121
commit b9718fe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/homeassistant/config_entries.py b/homeassistant/config_entries.py
@@ -929,6 +929,8 @@ def async_create_task(
         task = hass.async_create_task(
             target, f"{name} {self.title} {self.domain} {self.entry_id}", eager_start
         )
+        if task.done():
+            return task
         self._tasks.add(task)
         task.add_done_callback(self._tasks.remove)
 
@@ -949,6 +951,8 @@ def async_create_background_task(
         target: target to call.
         """
         task = hass.async_create_background_task(target, name, eager_start)
+        if task.done():
+            return task
         self._background_tasks.add(task)
         task.add_done_callback(self._background_tasks.remove)
         return task

diff --git a/homeassistant/core.py b/homeassistant/core.py
@@ -637,6 +637,8 @@ def async_create_task(
         """
         if eager_start:
             task = create_eager_task(target, name=name, loop=self.loop)
+            if task.done():
+                return task
         else:
             task = self.loop.create_task(target, name=name)
         self._tasks.add(task)
@@ -657,6 +659,8 @@ def async_create_background_task(
         """
         if eager_start:
             task = create_eager_task(target, name=name, loop=self.loop)
+            if task.done():
+                return task
         else:
             task = self.loop.create_task(target, name=name)
         self._background_tasks.add(task)