Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ElevenLabs to core #5726

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Conversation

sorgfresser
Copy link
Contributor

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Copying the elevenlabs icons for the newly added core integration

Checklist

I just used cp, so these checks shouldn't have changed.

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@sorgfresser
Copy link
Contributor Author

@joostlek I copied the files for now as there are existing hacs integrations

@joostlek
Copy link
Member

joostlek commented Aug 2, 2024

Please remove from custom

@sorgfresser
Copy link
Contributor Author

Done @joostlek! Should I squash the two commits?

@joostlek
Copy link
Member

joostlek commented Aug 3, 2024

We squash them with merging

@joostlek
Copy link
Member

joostlek commented Aug 3, 2024

By the way, did you send your discord username?

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sorgfresser 👍

@sorgfresser
Copy link
Contributor Author

By the way, did you send your discord username?

sorgfresser, same as Github. Thanks!!
home-assistant/core#115645 (comment)

@c0ffeeca7 c0ffeeca7 merged commit c6910ea into home-assistant:master Aug 3, 2024
5 checks passed
Athozs pushed a commit to Athozs/brands that referenced this pull request Aug 30, 2024
* Copy ElevenLabs to core

* Remove elevenlabs from custom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants