Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go for Health Connect approval again for appeal approved permissions #4964

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

dshokouhi
Copy link
Member

Summary

🤞

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

this is a short list but it was approved during our appeal so hopefully we can get out foot in the door (again) i vote we push to prod again if approved.

@jpelgrom
Copy link
Member

jpelgrom commented Jan 9, 2025

Changelog should be updated as we did a stable release. Maybe also reflect what is enabled vs not in the docs?

@dshokouhi
Copy link
Member Author

Changelog should be updated as we did a stable release. Maybe also reflect what is enabled vs not in the docs?

let me update the changelog here and docs if we get approval?

@jpelgrom
Copy link
Member

jpelgrom commented Jan 9, 2025

I did not mean the changelog version number, but the items in there as we're back to 0 new features/updates, or do you want to try and push this immediately to stable?

@dshokouhi
Copy link
Member Author

I did not mean the changelog version number, but the items in there as we're back to 0 new features/updates, or do you want to try and push this immediately to stable?

ah oops, ok let me reset it. Personally was thinking of going to prod if they approve the beta build

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied with current change log: do a beta tag > production release when approved now, shortly after 2025.1.1 so no reset.

@dshokouhi dshokouhi merged commit de6d1ee into home-assistant:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants