Unlink saving crash stacktrace from Sentry #4895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of years ago I added saving uncaught fatal exceptions to the app to display them to the user, using a hook provided by Sentry. Turns out it is not too difficult to do it without Sentry, so this PR changes that.
It will still pass exceptions on to Sentry if initialized (tested). Saving the crash is always on now because it no longer involves Sentry/a 3rd party you might want to switch off.
(Maybe it will also catch more stuff now that it is simpler, because I feel like recently it hasn't worked very well.)
Screenshots
I did code an exception to test but actually got a real crash :)
Crash text (note that I switched timestamp/thread after taking the screenshot)
Link to pull request in Documentation repository
n/a
Any other notes