Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle two recent Compose deprecations #4879

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Dec 5, 2024

Summary

Updates to handle the following two minor Compose deprecations that appeared recently:

  • constructor(capitalization: KeyboardCapitalization = ..., autoCorrect: Boolean, keyboardType: KeyboardType = ..., imeAction: ImeAction = ..., platformImeOptions: PlatformImeOptions? = ..., showKeyboardOnFocus: Boolean? = ..., hintLocales: LocaleList? = ...): KeyboardOptions' is deprecated. Please use the new constructor that takes optional autoCorrectEnabled parameter.
  • ClickableText(text: AnnotatedString, modifier: Modifier = ..., style: TextStyle = ..., softWrap: Boolean = ..., overflow: TextOverflow = ..., maxLines: Int = ..., onTextLayout: (TextLayoutResult) -> Unit = ..., onClick: (Int) -> Unit): Unit' is deprecated. Use Text or BasicText and pass an AnnotatedString that contains a LinkAnnotation.

Screenshots

The "Learn more" text now matches the other text size instead of being slightly smaller (even though we never set the size?)

Light Dark
Welcome to Home Assistant Companion screen with a 'Learn more' link matching the main intro text size, light mode Welcome to Home Assistant Companion screen with a 'Learn more' link matching the main intro text size, dark mode

Link to pull request in Documentation repository

n/a

Any other notes

@frenck frenck merged commit c176601 into home-assistant:master Dec 6, 2024
4 checks passed
@jpelgrom jpelgrom deleted the compose-keyboardoptions-clickabletext-deprecation branch December 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants