Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for progress notifcations #4799

Merged

Conversation

EarMaster
Copy link
Contributor

@EarMaster EarMaster commented Nov 10, 2024

Summary

Added progress, progress_max and progress_indeterminate to the notification manager to allow progress bars in notifications.

FCM Push: home-assistant/mobile-apps-fcm-push#173

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#1136

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EarMaster

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dshokouhi
Copy link
Member

Thanks for the PR 🙏 ! As we are adding new notification parameters we need to add them to the FCM repo: https://github.com/home-assistant/mobile-apps-fcm-push/blob/main/functions/android.js#L46-L58

@EarMaster
Copy link
Contributor Author

Thanks for the PR 🙏 ! As we are adding new notification parameters we need to add them to the FCM repo: https://github.com/home-assistant/mobile-apps-fcm-push/blob/main/functions/android.js#L46-L58

Thanks for the hint.
home-assistant/mobile-apps-fcm-push#173

@EarMaster EarMaster marked this pull request as ready for review November 10, 2024 23:17
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏 tested changes locally and works well here.

@dshokouhi dshokouhi merged commit 74f8b24 into home-assistant:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants