-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for progress notifcations #4799
Added support for progress notifcations #4799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EarMaster
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks for the PR 🙏 ! As we are adding new notification parameters we need to add them to the FCM repo: https://github.com/home-assistant/mobile-apps-fcm-push/blob/main/functions/android.js#L46-L58 |
Thanks for the hint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙏 tested changes locally and works well here.
Summary
Added
progress
,progress_max
andprogress_indeterminate
to the notification manager to allow progress bars in notifications.FCM Push: home-assistant/mobile-apps-fcm-push#173
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1136