Add QR code scanner for frontend #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a overlay with cutout in the middle / on the side, matching design and Google's barcode scanner - Working button for toggling the flashlight on and off
- Fix camera remaining active when the activity is paused (for example, by going to another app) - Set the app's theme - Add more UI parts: title, subtitle, optional action button
- Request permission when launched, and add snackbar when permission is denied - Add flashlight button and position it to line up with the frame - Make title/subtitle/action dynamic - Fix double scrim for system bars on older API levels
jpelgrom
force-pushed
the
barcodescanner
branch
from
f441231 to
9ef00c8
Compare
- The type for external bus messages should be command, with the bar_code/* in the key command - Send aborted when closing the scanner using back
# Conflicts: # gradle/libs.versions.toml
- Make sure the device actually has a camera and is not automotive
|
External bus functionality implemented, this should be good to review now! qr.mp4 |
dshokouhi
approved these changes
May 1, 2024
# Conflicts: # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a QR code scanner to the app (home-assistant/frontend#19570). This uses the 'old' ZXing library because something like MLKit is not 100% open source and would exclude the minimal flavor.
Screenshots
Recreated from design in frontend PR and the Google Matter barcode scanner which closely matches the design sample
Link to pull request in Documentation repository
n/a
Any other notes