Fix rotary input after first screen & for picker #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The recent switch to Horologist modifiers for rotary input broke after the first screen because of manual focus requesting, and the refresh interval picker in general so also switch that to a Horologist modifier.
JBassett
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recent switch to Horologist modifiers for rotary input in #3876 broke rotary input after the first screen, presumably because of manual focus requesting, and the refresh interval picker in general. This PR fixes it by removing manual focus requesting (like in the Horologist sample) and also switches the refresh picker to a Horologist modifier.
Tested it on a Galaxy Watch 4 where now screens after the first one seem to work again.
Closes #3879, the dependency bump was required to get the rotary scroll adapter function for pickers.
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes