Fix device controls lock toggle action (invert) #3869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Sep 15, 2023
|
Lets hold off on merging this as it won't be valid if we merge #3862 once corrected |
|
I'll just close this one, as we both agree reverting the active state for locks is the correct option here to match Android behavior for controls/other Android apps (also the frontend doesn't show locks as binary as Android). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The active state for locks was changed to match the frontend, meaning that locked is now inactive. Update the device controls toggle action accordingly. Other toggles (qs, Wear) aren't affected as they use the entity state object to determine the call to use. Fixes #3867.
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes