Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread updates: add border agent ID, multiserver improvements #3820

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Thread updates: add border agent ID, multiserver improvements #3820

merged 3 commits into from
Aug 26, 2023

Conversation

jpelgrom
Copy link
Member

Summary

Updates to the Thread credentials sync:

  • Home Assistant core 2023.9 will expose the border agent ID for networks meaning we can finally move away from the placeholder ID if provided, otherwise continue using the placeholder ID.
  • Improve multiserver handling. Because there is no UI provided by Play Services to select a Thread network to use, to prevent confusion the app needs to make sure only one HA credential is added. This means deleting orphaned/old credentials and credentials from other servers on sync, before adding the server preferred credential.

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

@jpelgrom
Add/update/delete Thread credentials by border agent ID
2a0e6ba
@jpelgrom
Multiserver: only keep one HA credential, handle credentials for dele…
41bb42b 
…ted servers

 - Make sure the app only stores one HA credential that matches the preferred credential for the server executing the sync.
 - Create an 'orphaned Thread credentials' system to be able to delete credentials for servers that have been previously deleted.
@JBassett JBassett merged commit 6d4fa06 into home-assistant:master Aug 26, 2023
@jpelgrom jpelgrom deleted the thread-border-agent-id branch August 26, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshokouhi dshokouhi dshokouhi approved these changes

@JBassett JBassett JBassett approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpelgrom @JBassett @dshokouhi