-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt at a new release model. #3597
Conversation
This also seems to remove the automated deploy to the Amazon App Store, correct? |
Yeah, it appears that it was only staging the deploy and manual intervention was needed to actually release it with the old system. If we find a tool that will actually release the update I would love to add it back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand what will happen:
- all building happens in
onPush.yml
- building + internal track push happens on merge or tag
- GitHub pre-release and internal track to beta track push happens on tag
- tags are created weekly and on the first of each month, and will create a GitHub pre-release
- stable releases aren't new tags but instead editing an existing pre-release/tag
Assuming that is correct, won't the scheduled activities push more 'new' releases where there might not be any changes (= same release contents and version), which the Play Store will reject?
./gradlew :reckonTagPush -Preckon.stage=final
doesn't work for me locally with the error 'Task '.stage=final' not found in root project 'home-assistant-android' and its subprojects.' but as it is in the documentation I'm not sure if it doesn't work or if it's something in my environment.
@@ -92,6 +92,10 @@ jobs: | |||
restore-keys: | | |||
${{ runner.os }}-gradle- | |||
|
|||
- uses: ./.github/actions/create-release-number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do PRs get a release number now? Local builds work fine without running the action, I got version name 2023.6.1-beta.0.14+a532fb4
without any config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was primarily using it to test, but since it's not signed with the real keys it should be safe to have actual version/build numbers in PRs.
Think this is a problem with your setup, I validated again and it was working. |
Adding the tag will bump the version number making it a "new" build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience with the answers.
Let's see if this flow improves the release process :)
Summary
Attempting to simplify the release cycle and hopefully improve our review times with Google. Our weekly play store release will now be tagged and ready for promotion rather than needing another review.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes