Improve sensor re-registration on app version change for offline server #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent the sensor worker runs from taking a long time when the app version changes if a server is offline due to reregistration of all servers (~15 min), by skipping these re-registrations if it fails with an exception that indicates offline/network issues.
dshokouhi
approved these changes
Feb 28, 2023
JBassett
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the
SensorWorkerruns from taking a long time if a server is offline when the app version changes due to re-registration of all sensors (~15 min, runs sequentially), by skipping these re-registrations if one fails with an exception that indicates the server can't be reached.This isn't a new issue but more obvious with multiserver as it is more likely to have a server that is frequently offline/unreachable. The app version doesn't change with debug builds so this was spotted by @dshokouhi with updates on the internal test track :)
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes