Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication to widget buttons #2798

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Add authentication to widget buttons #2798

merged 1 commit into from
Sep 5, 2022

Conversation

andyboeh
Copy link
Contributor

Summary

Button widgets on Android do not require an authentication, even if the app is set to require authentication. This is especially annoying if you want an easy way to open the garage door while still providing a basic level of security.

This PR adds a per-button setting "Require authentication" that triggers authenticating via device credentials - biometrics, pattern ...

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#792

Any other notes

See #1851

@homeassistant
Copy link
Contributor

Hi @andyboeh,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@jpelgrom jpelgrom linked an issue Aug 16, 2022 that may be closed by this pull request
Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few notes.

Have you tried using a transparent activity? I think it looks better but haven't extensively tested (also can't make a screenshot due to the keyguard 😉).

@andyboeh
Copy link
Contributor Author

I didn't know that something like a transparent theme existed - I've never written an Android app, only contributed to some, so my knowledge is very limited on this end. I'll see how it looks / works.

@andyboeh
Copy link
Contributor Author

@jpelgrom I think that I addressed all your comments. The transparent theme looks indeed very good, thanks for the suggestion!

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, sorry I didn't catch it sooner.

@andyboeh
Copy link
Contributor Author

No worries, we are constantly making progress and you are very quick in doing the review!

@jpelgrom
Copy link
Member

I think it's good, just need you to resolve the merge conflict.

@andyboeh
Copy link
Contributor Author

Rebased and pushed :)

@andyboeh
Copy link
Contributor Author

andyboeh commented Sep 1, 2022

Do I need to do something else before this can be merged?

@jpelgrom
Copy link
Member

jpelgrom commented Sep 1, 2022

Do I need to do something else before this can be merged?

Sorry I forgot to click on the approve button ☺️, no additional changes necessary as far as I'm concerned.

Merging feature PRs was on hold for the last week or so because of the new release. Usually @JBassett does a final review of PRs and will merge once he approves.

@JBassett JBassett merged commit 6b06e0d into home-assistant:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIN / Biometrics for widgets
4 participants