Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCHITECTURE] Let's do some quality #15

Merged
merged 9 commits into from
Nov 10, 2019
Merged

[ARCHITECTURE] Let's do some quality #15

merged 9 commits into from
Nov 10, 2019

Conversation

CedrickFlocon
Copy link
Member

@CedrickFlocon CedrickFlocon commented Nov 5, 2019

Dependency injection / test framework and test / Read me setup ...

@CedrickFlocon CedrickFlocon changed the title [ARCHITECTURE] [ARCHITECTURE] Let's do some quality Nov 5, 2019
@BCNelson
Copy link
Contributor

BCNelson commented Nov 9, 2019

@CedrickFlocon When are you planning on merging these changes? I would like to help but don't want to make it hard to merge in your branch.

@CedrickFlocon
Copy link
Member Author

CedrickFlocon commented Nov 9, 2019

@BCNelson It's almost finish, I hope at the end of the weekend.
I need to create a dependency graph and use this new component in the presenter layer.

@CedrickFlocon CedrickFlocon marked this pull request as ready for review November 10, 2019 20:41
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@balloob balloob merged commit 3219504 into home-assistant:master Nov 10, 2019
@CedrickFlocon CedrickFlocon deleted the architecture branch November 10, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants