-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google_assistant: Deprecate Google Assistant add-on #3870
Conversation
The Google Assistant SDK Python library is no longer developed. Currently it seems no longer possible to setup this add-on since the OAuth Out-of-Band flow has been deprecated.
📝 WalkthroughWalkthroughThe pull request introduces deprecation notices for the Google Assistant SDK add-on in Home Assistant. The changes are focused on signaling the end of development and support for this integration, with updates made to both the README.md file and the configuration YAML file. The modifications clearly communicate that the Google Assistant SDK is no longer actively maintained, and new setups are not possible due to deprecated OAuth out-of-band (OOB) flow. Changes
These changes formally mark the Google Assistant SDK integration as deprecated, providing clear guidance to users about its current status and limitations. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
google_assistant/README.md (1)
3-9
: Improve the deprecation notice formatting and clarityThe deprecation notice effectively communicates the status, but could be enhanced with these changes:
- Add a comma after "Hence" for better readability
- Consider making the deprecation status more prominent by adding "DEPRECATED" to the document title
-# Home Assistant Add-on: Google Assistant SDK +# Home Assistant Add-on: Google Assistant SDK (DEPRECATED) > [!CAUTION] > **Deprecation notice** > The [Google Assistant SDK for device][google-assistant-sdk] Python library > this add-on depends on is no longer developed and has been archived. The > OAuth out-of-band (OOB) flow used by the add-on has been deprecated as well. -> Hence a new setup is currently no longer possible. +> Hence, a new setup is currently no longer possible.🧰 Tools
🪛 LanguageTool
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...e add-on has been deprecated as well. > Hence a new setup is currently no longer poss...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
google_assistant/README.md
(2 hunks)google_assistant/config.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- google_assistant/config.yaml
🧰 Additional context used
📓 Path-based instructions (1)
google_assistant/README.md (6)
Pattern */**(html|markdown|md)
: - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern */**(html|markdown|md)
: - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern */**(html|markdown|md)
: - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern */**(html|markdown|md)
: - Use sentence-style capitalization also in headings.
Pattern */**(html|markdown|md)
: do not comment on HTML used for icons
Pattern */**(html|markdown|md)
: Avoid flagging inline HTML for embedding videos in future reviews for this repository.
🪛 LanguageTool
google_assistant/README.md
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...e add-on has been deprecated as well. > Hence a new setup is currently no longer poss...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (1)
google_assistant/README.md (1)
31-31
: LGTM!
The link to the Google Assistant SDK repository is properly formatted and provides valuable reference to users.
The Google Assistant SDK Python library is no longer developed. Currently it seems no longer possible to setup this add-on since the OAuth Out-of-Band flow has been deprecated.
Summary by CodeRabbit
Documentation
Configuration Changes
stage
attribute fromexperimental
todeprecated
in the configuration file, reflecting the lack of active support for the Google Assistant SDK.