-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matter_server: Add beta flag #3282
Merged
agners
merged 2 commits into
home-assistant:master
from
agners:add-beta-flag-to-matter-server
Oct 26, 2023
Merged
matter_server: Add beta flag #3282
agners
merged 2 commits into
home-assistant:master
from
agners:add-beta-flag-to-matter-server
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new flag which allows to install the latest pre-release of the Python Matter Server. This is useful for testing new (pre-)releases before bumping the add-on. Previously we tried different approaches like a separate beta version of the add-on. This has the problem that it has it's separate data store (means no more devices in case the non-beta add-on has been used previously) and it gets chaotic as the Matter integration is still trying to start the non-beta version of the add-on. With this attempt we can reuse the same add-on for testing. The downside is once new OS dependencies are required, those won't be added. In that case a regular add-on version bump would be necessary first.
frenck
approved these changes
Oct 25, 2023
agners
force-pushed
the
add-beta-flag-to-matter-server
branch
from
October 25, 2023 14:07
eb9b633
to
8979636
Compare
Kind request to release this before/with the HA core beta cut. |
Co-authored-by: Franck Nijhof <[email protected]>
agners
added a commit
to home-assistant/addons-development
that referenced
this pull request
Nov 20, 2023
Maintaining Matter Server beta as a separate add-on has the problem that the Matter fabric data is separated from the official/non-beta add-on. Furthermore the Matter integration installs and starts the official add-on which causes furhter complications. Adjusting the URL to use the beta add-on is also non-trivial. For these reasons, the offical Matter Server add-on received a beta flag a while ago (see home-assistant/addons#3282). Drop the pure beta version as it is no longer required.
agners
added a commit
to home-assistant/addons-development
that referenced
this pull request
Nov 20, 2023
Maintaining Matter Server beta as a separate add-on has the problem that the Matter fabric data is separated from the official/non-beta add-on. Furthermore the Matter integration installs and starts the official add-on which causes furhter complications. Adjusting the URL to use the beta add-on is also non-trivial. For these reasons, the offical Matter Server add-on received a beta flag a while ago (see home-assistant/addons#3282). Drop the pure beta version as it is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new flag which allows to install the latest pre-release of the Python Matter Server. This is useful for testing new (pre-)releases before bumping the add-on.
Previously we tried different approaches like a separate beta version of the add-on. This has the problem that it has its separate data store (means no more devices in case the non-beta add-on has been used previously) and it gets chaotic as the Matter integration is still trying to start the non-beta version of the add-on.
With this attempt we can reuse the same add-on for testing. The downside is once new OS dependencies are required, those won't be added. In that case a regular add-on version bump will be necessary first.