Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request while protocol context is shutting down #814

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Feb 3, 2024

  • If the protocol context is shutting down we're not allowed to make new requests with the context.
  • Add a check if we're shutting down the protocol context when getting the context.
  • This should fix reqeusts that are made after the protocol context has begun to shutdown but before the protocol context has completed the reset.
  • Example stacktrace (first one):
    Tradfri: manual reload of the integration fails home-assistant/core#105004 (comment)
  • Requests that are already in flight before the protocol context begins the shutdown are up to aiocoap to handle and flush.

@MartinHjelmare MartinHjelmare changed the title Fix request while context is shutting down Fix request while protocol context is shutting down Feb 3, 2024
@frenck frenck merged commit 948dbcc into master Feb 3, 2024
2 checks passed
@frenck frenck deleted the fix-context-shutdown-access branch February 3, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants