Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make device info firmware version optional #812

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Feb 1, 2024

  • The device info firmware version has been reported to sometimes be missing in the response from the gateway.
  • Make it optional since it's not required for operation.
  • This is a breaking change.

fixes #810

@MartinHjelmare MartinHjelmare merged commit 5ff74f2 into master Feb 1, 2024
2 checks passed
@MartinHjelmare MartinHjelmare deleted the make-device-info-firmware-version-optional branch February 1, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic.error_wrappers.ValidationError: 1 validation error for DeviceResponse
2 participants