Add mounts API #32
Merged
Add mounts API #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdegat01
commented
Nov 25, 2024
|
|
||
| name: str | ||
| read_only: bool | ||
| state: MountState | None |
There was a problem hiding this comment.
Note to reviewers: the user_path field added in home-assistant/supervisor#5438 was specifically excluded from here. The implementation plan for cloud backup is still under debate and so this field may be removed before next Supervisor beta. I'll add the field in a follow-up if it remains.
MartinHjelmare
approved these changes
Nov 26, 2024
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class MountRequest(ABC): # noqa: B024 |
There was a problem hiding this comment.
Why do we need to disable the ruff rule here but not in the other ABC classes?
There was a problem hiding this comment.
I believe its because the only field it has is optional. As long as there is at least one required field that doesn't show up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add mounts API to client library