Don't add automatically ffmpeg audio transcoding #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhaus
added
bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 7 7
Lines 298 298
Branches 50 50
=======================================
Hits 292 292
Misses 4 4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
edenhaus
commented
Nov 6, 2024
|
|
||
| @handle_error | ||
| async def add(self, name: str, source: str) -> None: | ||
| async def add(self, name: str, sources: str | list[str]) -> None: |
There was a problem hiding this comment.
Needed to move the function add before list otherwise mypy get confused with the list[str] type
There was a problem hiding this comment.
How is the string type handled for sources parameter? Is that a single source? Can that be passed as is?
There was a problem hiding this comment.
See de00a76 (#24)
It will only add one src query param instead of multiple
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Until now, we automatically added
f"ffmpeg:{name}#audio=opus"as a second stream to have WebRTC audio support.But there are cameras which don't have audio at all, and therefore the caller should decide, which sources should be added.