Audio URLs #247
Merged
Audio URLs #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are you planning to use this in Home Assistant? |
|
Add streaming support to the Android ip webcam and use ffmpeg to add the AAC stream, a proof of concept is here: https://github.com/regulad/hass-android_ip_webcam-audio/blob/master/custom_components/android_ip_webcam/camera.py |
|
I don't think we'll accept that code in the core integration as it has too much AV details and also socket code. That kind of code should be done in a 3rd party library. In a custom integration you can of course do what you want. Do you still want to pursue this PR? |
|
Yes, of course. That is only a proof of concept, I will rework it once this PR is complete and the audio is added to the backend library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Android IP webcam's Audio URLs. I plan to use this change to enable audio in the Home Assistant integration.