Add service data #11
Merged
Add service data #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Oct 18, 2023
| except InvalidCommand: | ||
| return False | ||
| return improv_service_data.state not in ( | ||
| prot.State.PROVISIONING, |
There was a problem hiding this comment.
I'm not sure we should filter out devices which are provisioning?
|
What's the goal with this PR? |
The current state and capabilities are now in the advertisement data so when it changes to already provisioned or provisioning we will no longer offer the device to the user via discovery. The previous design relied on the service uuid disappearing, but service uuids only expire when the device goes out of range (maybe not even than depending on the Bluetooth stack). If the device stays in range forever the previous design would offer to set up WiFi even though it was already provisioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary changes to support an updated version of the Improv via BLE spec which adds service data
ESPHome PR: esphome/esphome#5553
Note: The spec has not yet been updated