Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower close() logging level to debug when the process is already terminated #180

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Lower close() logging level to debug when the process is already terminated #180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6724c40
Close process in tools functions only if needed
nmaggioni Nov 7, 2024
036f39a
Revert "Close process in tools functions only if needed"
nmaggioni Nov 7, 2024
91b98d9
Lower close() logging level to debug
nmaggioni Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions haffmpeg/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ async def get_image(
return None

finally:
await self.close(0)
if self.is_running:
await self.close(0)


class FFVersion(HAFFmpeg):
Expand Down Expand Up @@ -87,6 +88,7 @@ async def get_version(self, timeout: int = 15) -> Optional[str]:
self.kill()

finally:
await self.close(0)
if self.is_running:
await self.close(0)

return None