Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in HtmlParser #9

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

estrattonbailey
Copy link
Contributor

We're integrating Tiptap, which relies on this library, and noticed that trying to generateJSON from a text fragment << results in an infinite loop which crashes the browser.

This PR fixes what I think is a small bug, where the string slicing was off-by-one due to the substring(1) call.

@estrattonbailey estrattonbailey changed the title Fix recursion error in HtmlParser Fix infinite loop in HtmlParser Oct 10, 2023
@holtwick holtwick merged commit 3669c26 into holtwick:master Oct 11, 2023
@holtwick
Copy link
Owner

Thank you very much for fixing this bug. I'll do a new release after testing.

@estrattonbailey
Copy link
Contributor Author

@holtwick thanks for the quick turnaround! We really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants