Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine throttle implementations #7480

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Combine throttle implementations #7480

merged 3 commits into from
Nov 11, 2024

Conversation

philippjfr
Copy link
Member

We had two throttle JS implementations, both were flawed.

  1. The one used for throttling streaming HTML output was actually debouncing, causing updates to be stalled until the streaming stopped.
  2. The implementation used elsewhere was mostly okay but did not implement trailing execution which meant that if the final update was never executed if the previous update occurred within the timeout period.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (cf9dc6b) to head (7793f0b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7480   +/-   ##
=======================================
  Coverage   82.36%   82.37%           
=======================================
  Files         338      338           
  Lines       50964    50964           
=======================================
+ Hits        41977    41981    +4     
+ Misses       8987     8983    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 89b0bc6 into main Nov 11, 2024
18 checks passed
@philippjfr philippjfr deleted the simplify_throttle branch November 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant