Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator docs: update links, version and remove unused imports #4494

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 3, 2023

Fixes #4405

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #4494 (150d489) into main (ecd08bd) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4494      +/-   ##
==========================================
- Coverage   82.21%   82.13%   -0.08%     
==========================================
  Files         243      243              
  Lines       35355    35355              
==========================================
- Hits        29066    29038      -28     
- Misses       6289     6317      +28     
Flag Coverage Δ
ui-tests 35.52% <ø> (-0.27%) ⬇️
unitexamples-tests 74.16% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_misc.py 33.33% <0.00%> (-64.11%) ⬇️
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/conftest.py 88.08% <0.00%> (-1.28%) ⬇️
panel/tests/util.py 88.18% <0.00%> (-0.91%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 98.22% <0.00%> (+0.15%) ⬆️
panel/reactive.py 79.68% <0.00%> (+0.39%) ⬆️
panel/io/cache.py 85.34% <0.00%> (+0.43%) ⬆️
panel/io/state.py 70.56% <0.00%> (+0.51%) ⬆️
panel/io/reload.py 73.91% <0.00%> (+4.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit e6a6287 into main Mar 4, 2023
@philippjfr philippjfr deleted the tabulator_docs_improvements branch March 4, 2023 01:00
"cell_type": "markdown",
"metadata": {},
"source": [
"These and other available *Tabulator* options are listed at http://tabulator.info/docs/5.3/options. \n",
"These and other available *Tabulator* options are listed at http://tabulator.info/docs/5.4/options. \n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been https @maximlt :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: Mixed Content https vs http issue
3 participants