Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for no geoviews explorer #1451

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Fix logic for no geoviews explorer #1451

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fa0251
fix logic
ahuang11 Oct 29, 2024
c3c5a2a
simplify
ahuang11 Oct 29, 2024
b441bda
add test
ahuang11 Oct 29, 2024
681fa4f
refactor into util and test
ahuang11 Oct 30, 2024
bae3bd7
use findspec properly mock
ahuang11 Oct 30, 2024
0054eea
add back
ahuang11 Oct 30, 2024
31df383
refactor to always attempt to import
maximlt Dec 12, 2024
757dfcf
Merge branch 'main' into fix_ui_without_geoviews
maximlt Dec 12, 2024
f8e1a30
fix typing?
maximlt Dec 12, 2024
70e59b3
don't bother with type hints yet
maximlt Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hvplot/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import sys
import types
import typing

from collections.abc import Hashable

Expand Down Expand Up @@ -730,7 +731,7 @@ def import_datashader():
return datashader


def import_geoviews() -> types.ModuleType | None:
def import_geoviews() -> typing.Union[types.ModuleType, None]:
maximlt marked this conversation as resolved.
Show resolved Hide resolved
geoviews = None
try:
import geoviews
Expand Down
Loading