Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Remove Polars PerformanceWarning #1418

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 23, 2024

Remove this warning:
image

@hoxbro hoxbro force-pushed the remove_performance_warning branch from 1aad1ff to 701dbb9 Compare September 23, 2024 12:34
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (efeda78) to head (701dbb9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
hvplot/plotting/core.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
+ Coverage   88.73%   88.89%   +0.15%     
==========================================
  Files          51       51              
  Lines        7592     7656      +64     
==========================================
+ Hits         6737     6806      +69     
+ Misses        855      850       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from maximlt September 23, 2024 12:51
@hoxbro hoxbro added the polars label Sep 23, 2024
hvplot/plotting/core.py Outdated Show resolved Hide resolved
@hoxbro hoxbro changed the title Remove polars performance warning PERF: Remove Polars PerformanceWarning Sep 24, 2024
@maximlt maximlt merged commit 10d53b4 into main Sep 25, 2024
@maximlt maximlt deleted the remove_performance_warning branch September 25, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants