Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mutate data when using custom text format #1352

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Do not mutate data when using custom text format #1352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd1953d
do not mutate data
ahuang11 Jun 12, 2024
5a176c8
address comment
ahuang11 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hvplot/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2566,6 +2566,7 @@ def labels(self, x=None, y=None, data=None):
self._error_if_unavailable('labels')
self.use_index = False
data, x, y = self._process_chart_args(data, x, y, single_y=True)
data = data.copy()
maximlt marked this conversation as resolved.
Show resolved Hide resolved

text = self.kwds.get('text')
if not text:
Expand Down
1 change: 1 addition & 0 deletions hvplot/tests/testcharts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ def test_labels_format(self):
plot = self.df.hvplot('x', 'y', text='({x}, {y})', kind='labels')
assert list(plot.dimensions()) == [Dimension('x'), Dimension('y'), Dimension('label')]
assert list(plot.data['label']) == ['(1, 2)', '(3, 4)', '(5, 6)']
assert 'label' not in self.df

def test_labels_no_format_edge_case(self):
plot = self.edge_df.hvplot.labels('Longitude', 'Latitude')
Expand Down
Loading