Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set the background color with bgcolor #1308

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Allow to set the background color with bgcolor #1308

merged 2 commits into from
Apr 16, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Apr 10, 2024

Implements #636

@droumis FYI I have noticed that the converter __init__ signature does not include this kind of plot options passed down to HoloViews. Perhaps they should be added to the signature to later be included in some API reference docs.

@maximlt maximlt added this to the 0.9.3 milestone Apr 12, 2024
@droumis
Copy link
Member

droumis commented Apr 12, 2024

@droumis FYI I have noticed that the converter init signature does not include this kind of plot options passed down to HoloViews. Perhaps they should be added to the signature to later be included in some API reference docs.

Yep, I think it would help most for discoverability via auto-complete

@maximlt maximlt merged commit ce7af40 into main Apr 16, 2024
5 of 9 checks passed
@maximlt maximlt deleted the add_bgcolor branch April 16, 2024 07:52
@maximlt maximlt mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants