correctly fall back to all numeric polars cols when y is not specified #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure they're included in columns set if x or y is None
hoxbro
reviewed
Jan 3, 2024
kevinheavey
changed the title
|
Failing tests are likely to be because of conda-forge/polars-feedstock#205 Can you make a polars pin in setup.py for now? |
|
The failing test is because of the change in this PR. The test should be fixed, either with:
I don't have any preference for the two options. |
hoxbro
approved these changes
Jan 5, 2024
maximlt
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246