Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polars in hvplot.plot: avoid registering the hvplot accessor and simple test #1222

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Polars in hvplot.plot: avoid registering the hvplot accessor and simple test #1222

merged 2 commits into from
Dec 21, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 21, 2023

Follow-up of to add a simple test and to avoid registering the hvplot accessor, as I don't think this was intended.

@maximlt maximlt requested a review from hoxbro December 21, 2023 10:43
hoxbro
hoxbro approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny comment, but nothing that blocks this PR.

hvplot/tests/testplotting.py Outdated Show resolved Hide resolved
@maximlt maximlt merged commit 0e5c199 into main Dec 21, 2023
8 checks passed
@maximlt maximlt deleted the test_plot_polars branch December 21, 2023 19:10
@hoxbro hoxbro mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro hoxbro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximlt @hoxbro