Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues in explorer #1197

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix minor issues in explorer #1197

merged 3 commits into from
Nov 14, 2023

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Nov 11, 2023

Tweaks to labels, placeholders, margins, layout of explorer, based on the minor issues listed here:
#1190

image

@maximlt
Copy link
Member

maximlt commented Nov 12, 2023

Why has the status bar been moved to the top? I'm much more used to having a status bar at the bottom, like in the Perspective viewer or in QGIS. That's where it usually is apparently:
image

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Nov 12, 2023

I personally do not think the Live Update should be called "Status Bar" because "Status Bar" includes "messages, progress indicators, or status icons that convey important information to the user" and usually does not include something they can interact with.
image

Also, if it's on the bottom, the plot will push it out of view.

However, I don't have too strong of feelings on this so if you do, I'm fine with reverting it to the bottom.

:p ChatGPT suggests the container it resides in is the "Toolbar"
image

@maximlt
Copy link
Member

maximlt commented Nov 12, 2023

Yes probably status bar isn't the right word for that, although I've seen status bar used for components that do provide some control (like in QGIS).

It's easy to see though that we can add more of this kind of tools (reset, export, ...) and indicators (mouse position?), and I guess we should try to have them fit all in the same horizontal bar, so pick between top or bottom location. I think I prefer at the bottom as that's not the first thing users should see and click on, however I'm no UI/UX professional so I may just be plain wrong.

Also, if it's on the bottom, the plot will push it out of view

That's certainly the crux of the problem, in that we don't have very good control over the plot height, and even the Tab layout height that right now is as tall as its tallest item. There's a bit of a tension between allowing the users to set the plot dimensions (aka the explorer as a plot builder/editor/wizard) and giving them the best plot for them to explore their data (aka the explorer as the explorer!).

@ahuang11
Copy link
Collaborator Author

I think I prefer at the bottom as that's not the first thing users should see and click on

Referring to the Google Chrome layout, the back button is also not the first things users click on, but it's at the top. It looks better to me at the top.

image

@maximlt
Copy link
Member

maximlt commented Nov 14, 2023

Ok at the top is fine.

@ahuang11
Copy link
Collaborator Author

Can we merge this then or do you need more time to review it?

@maximlt
Copy link
Member

maximlt commented Nov 14, 2023

I'll review it later.

@maximlt
Copy link
Member

maximlt commented Nov 14, 2023

LGTM!

I still think the status/control bar is a bit in a weird place and looks to big for what it is, I don't want to block to PR for too long though as others depend on it and there may be conflicts. Hopefully one day we'll be supported by UI/UX engineers for this sort of design work!

image

@maximlt maximlt merged commit 40da24e into main Nov 14, 2023
8 checks passed
@maximlt maximlt deleted the explorer_minor_issues branch November 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants