Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update show method to return the configured Server or StoppableThread #1121

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Update show method to return the configured Server or StoppableThread #1121

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e04313
Update show method to return the configured Server | threading.Thread
dogbunny Jul 26, 2023
2c47ae1
Fix return type
dogbunny Aug 14, 2023
5a37baf
remove type annotations since hvplot isn't ready for them yet
dogbunny Aug 15, 2023
f99fb84
also remove future annotations
dogbunny Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions hvplot/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import panel as _pn
import param
import holoviews as _hv
Expand All @@ -8,7 +10,7 @@

save = _hv.save

def show(obj, title=None, port=0, **kwargs):
def show(obj, title=None, port=0, **kwargs) -> _pn.io.server.Server | _pn.io.server.StoppableThread:
hoxbro marked this conversation as resolved.
Show resolved Hide resolved
"""
Displays HoloViews objects in and outside the notebook

Expand All @@ -22,11 +24,14 @@ def show(obj, title=None, port=0, **kwargs):
Allows specifying a specific port
**kwargs: dict
Additional keyword arguments passed to Panel show method.
Returns
-------
a panel.io.server.Server | panel.io.server.StoppableThread (if threaded=true)
"""
if not isinstance(obj, _hv.core.Dimensioned):
raise ValueError('%s type object not recognized and cannot be shown.' %
type(obj).__name__)
_pn.pane.HoloViews(obj).show(title, port, **kwargs)
return _pn.pane.HoloViews(obj).show(title, port, **kwargs)


class hvplot_extension(_hv.extension):
Expand Down