separate import tests to see what's missing #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GeoViews depends on Cartopy and it seems like Cartopy depends on pyproj. So maybe it all comes down to just telling users to install GeoViews? Or did you observe cases where this was not true and needed the more fine grained error report you're implementing in this PR? |
|
I think this will make it a bit annoying if you have to install more than one of the packages. Maybe check all and then print out the packages which are missing? |
|
Thanks @raybellwaves, I took the liberty to update your PR by grouping the checks so that users get a single list of the missing dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to see which package(s) out of cartopy, geoview and pyproj are missing.