Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let process_crs try a few approaches before raising error #1026

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Mar 3, 2023

This PR makes the process_crs more generous in what it accepts and adds tests for the function.

@jsignell
Copy link
Member Author

jsignell commented Mar 3, 2023

I'm not 100% sure why the python 3.7 jobs are failing, but I would expect this new test to fail on main in all cases, so I think it would be reasonable to skip the new test for python 3.7 and call it a day. It is more likely tied to the pyproj version though. It looks like pyproj dropped support for python 3.7 a while back so that is probably related.

@hoxbro
Copy link
Member

hoxbro commented Mar 3, 2023

I'm fine with skipping the failing test on Python 3.7.

@maximlt
Copy link
Member

maximlt commented Mar 5, 2023

Thanks @jsignell ! Looks good to me.

Note for myself, crs accepts:

  • 'EPSG:<epsg_code>' as str
  • 'epsg:<epsg_code>' as str
  • <epsg_code> as int
  • PROJ.4 string
  • pyproj.Proj
  • cartopy.crs.CRS
  • and probably more :)

Also the utils that parse the projection like proj_to_cartopy and check_crs are from salem, need to check if they've been updated.

@maximlt maximlt merged commit 447199a into main Mar 5, 2023
@maximlt maximlt deleted the jsignell/crs branch March 5, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants