Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datashade don't update the dtype of the input DataFrame #6433

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 1, 2024

Fixes #6324

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Nov 1, 2024
@hoxbro hoxbro added this to the 1.20.0 milestone Nov 1, 2024
@hoxbro hoxbro changed the title fix: Don't convert original dataframe fix: datashade to not update the dtype of the input DataFrame Nov 1, 2024
@hoxbro hoxbro changed the title fix: datashade to not update the dtype of the input DataFrame fix: datashade don't update the dtype of the input DataFrame Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (4a9e609) to head (c3d88ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6433      +/-   ##
==========================================
- Coverage   88.52%   88.50%   -0.03%     
==========================================
  Files         323      323              
  Lines       68602    68619      +17     
==========================================
+ Hits        60727    60728       +1     
- Misses       7875     7891      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from philippjfr November 1, 2024 10:52
@philippjfr philippjfr merged commit d3aafd6 into main Nov 1, 2024
15 checks passed
@philippjfr philippjfr deleted the fix_category_overwrite branch November 1, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datashade operation update the dtype of the input DataFrame
2 participants