-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports for the multichan ts viewer demo #6264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you separate the imports from the code and put them above Generating Data
, together with hv.extension('bokeh')
. This seems to be like the other demos are structured, e.g.:
I re-ran the code for good measure and noticed there's a hover tool icon per curve in the toolbar. I don't remember seeing that before. I assume this is due to using the new hover_tooltips
option? I guess it's not exactly the expected outcome.
Correct, I had opened an issue here. As documented in that thread, the hover tools do get combined when it becomes a layout rather than an overlay. |
using hv.Layout((curves_overlay, hv.Empty())) actually combines the hover tools, but I don't think we should be advertising this workaround |
should be ready to merge. I'm guessing that the merging of the "subplot" tools within an overlay will be addressed another time, and otherwise should probably be default behavior for overlays, so there would be nothing to change further in this example. |
In future versions, we should update to utilize the wide df mapper approach and NdOverlay instead of hv.Dataset and Overlay. But some issues need to be addressed when combining data from multiple groups with the wide df approach, so let's merge this for now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.