Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports for the multichan ts viewer demo #6264

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

droumis
Copy link
Member

@droumis droumis commented Jun 6, 2024

No description provided.

@droumis droumis requested a review from maximlt June 6, 2024 12:28
@hoxbro hoxbro added the type: docs Related to the documentation and examples label Jun 6, 2024
@hoxbro hoxbro added this to the 1.19.0 milestone Jun 6, 2024
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate the imports from the code and put them above Generating Data, together with hv.extension('bokeh'). This seems to be like the other demos are structured, e.g.:

image


I re-ran the code for good measure and noticed there's a hover tool icon per curve in the toolbar. I don't remember seeing that before. I assume this is due to using the new hover_tooltips option? I guess it's not exactly the expected outcome.

image

@droumis
Copy link
Member Author

droumis commented Jun 7, 2024

I re-ran the code for good measure and noticed there's a hover tool icon per curve in the toolbar. I don't remember seeing that before. I assume this is due to using the new hover_tooltips option? I guess it's not exactly the expected outcome.

Correct, I had opened an issue here. As documented in that thread, the hover tools do get combined when it becomes a layout rather than an overlay.

@droumis
Copy link
Member Author

droumis commented Jun 7, 2024

using hv.Layout((curves_overlay, hv.Empty())) actually combines the hover tools, but I don't think we should be advertising this workaround

@droumis
Copy link
Member Author

droumis commented Jun 7, 2024

should be ready to merge. I'm guessing that the merging of the "subplot" tools within an overlay will be addressed another time, and otherwise should probably be default behavior for overlays, so there would be nothing to change further in this example.

@droumis
Copy link
Member Author

droumis commented Jun 12, 2024

In future versions, we should update to utilize the wide df mapper approach and NdOverlay instead of hv.Dataset and Overlay. But some issues need to be addressed when combining data from multiple groups with the wide df approach, so let's merge this for now.

@droumis droumis enabled auto-merge (squash) June 12, 2024 18:13
@droumis droumis merged commit aec168b into main Jun 12, 2024
14 checks passed
@droumis droumis deleted the subcoordy_demo_fix_imports branch June 12, 2024 18:43
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Related to the documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants