-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup popup #6207
Cleanup popup #6207
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6207 +/- ##
==========================================
- Coverage 88.12% 87.57% -0.56%
==========================================
Files 319 321 +2
Lines 67221 67289 +68
==========================================
- Hits 59241 58929 -312
- Misses 7980 8360 +380 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Simon Høxbro Hansen <[email protected]>
I can't judge if this is a better approach than the previous approach. If your opinion is that it is, you can merge the PR unless @philippjfr has a hard objection. |
I'm happy with this approach. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Changes so that internally, it will not touch existing_pane/popup_pane's param. That is up to the developer/user, so if it's
not visible
, the popup pane will not show, primarily for holoviz/holonote#101