Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package update - build and publish #6031

Merged
merged 48 commits into from
Mar 19, 2024
Merged

Package update - build and publish #6031

merged 48 commits into from
Mar 19, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 14, 2023

The following updates:

  • Don't use pyctdev for the PyPI package. Instead, use the build package.
  • Splitting building and publishing up for both PyPI and Conda.
  • Add artifacts to both
  • Add pip install step to check if the wheel can be installed, and do an import.
  • Add an approval step after the build and wait for all builds.
  • As both build steps take under two minutes to finish, I have set it up so they run on PRs. I am not sure about if this is needed. I can remove it again.

Example of workflow: https://github.com/holoviz/holoviews/actions/runs/7210047765

Screenshots of workflow:
 Screenshot 2023-12-14 15 13 09
 Screenshot 2023-12-14 15 13 22

 Screenshot 2023-12-14 15 56 22
 Screenshot 2023-12-14 15 56 44
 Screenshot 2023-12-14 15 58 12

Ref:

@hoxbro hoxbro force-pushed the package_update branch 2 times, most recently from c9eca16 to ad002d7 Compare December 14, 2023 09:47
[skip ci]
@hoxbro hoxbro force-pushed the package_update branch 2 times, most recently from 9786e65 to 5aa9859 Compare December 14, 2023 10:12
[skip ci]
[skip ci]
@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Dec 14, 2023
[skip ci]
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e23c3e9) 88.62% compared to head (cf6d373) 88.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6031   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         315      315           
  Lines       65636    65638    +2     
=======================================
+ Hits        58168    58170    +2     
  Misses       7468     7468           
Flag Coverage Δ
ui-tests 23.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro mentioned this pull request Mar 17, 2024
6 tasks
@hoxbro hoxbro changed the title Package update Package update - build and publish Mar 18, 2024
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@hoxbro hoxbro merged commit 0147837 into main Mar 19, 2024
11 checks passed
@hoxbro hoxbro deleted the package_update branch March 19, 2024 19:20
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants