-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support python3-only systems #5874
Conversation
I think this could cause problems with Windows. Can you make it an if statement? like if shutil.which("python"):
check_output(['python', '-c', dedent(check)])
else:
check_output(['python3', '-c', dedent(check)]) |
sorry for the force-pushes :( like this? |
Codecov Report
@@ Coverage Diff @@
## main #5874 +/- ##
==========================================
- Coverage 88.36% 88.34% -0.03%
==========================================
Files 310 310
Lines 63959 63956 -3
==========================================
- Hits 56519 56503 -16
- Misses 7440 7453 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No worries. Force push is part of life. And yes. |
Thank you for the PR. Failing PRs are unrelated. |
I thank you for the review :) it's been an honor. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Python 2 has been dead for some time and some rolling distros (like openSUSE Tumbleweed) don't have the
python
binary anymore. I think that checking for thepython3
binary is more inclusive and doesn't change the nature of the test.