Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Postpone bokeh.models import #764

Merged
merged 4 commits into from
Dec 16, 2024
Merged

perf: Postpone bokeh.models import #764

merged 4 commits into from
Dec 16, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 4, 2024

bokeh.models is a heavy module to import, so we will postpone it until something else imports it.

@hoxbro
Copy link
Member Author

hoxbro commented Nov 4, 2024

Failing test are fixed with #763

@hoxbro hoxbro requested a review from ahuang11 November 4, 2024 09:01
@hoxbro hoxbro changed the title enh: Postpone bokeh.models import refactor: Postpone bokeh.models import Nov 4, 2024
@hoxbro hoxbro changed the title refactor: Postpone bokeh.models import perf: Postpone bokeh.models import Nov 4, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.36%. Comparing base (4efca3b) to head (129402d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   69.34%   69.36%   +0.01%     
==========================================
  Files          45       45              
  Lines        4721     4726       +5     
==========================================
+ Hits         3274     3278       +4     
- Misses       1447     1448       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) December 16, 2024 07:58
@hoxbro hoxbro merged commit b0618a3 into main Dec 16, 2024
13 checks passed
@hoxbro hoxbro deleted the postpone_bokeh_import branch December 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant