Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize JS/TS codebase and upgrade to bokeh 3.4 #715

Merged
merged 12 commits into from
Mar 27, 2024

Conversation

mattpap
Copy link
Collaborator

@mattpap mattpap commented Mar 27, 2024

This PR:

  • upgrades tsconfig.json to match panel
  • adds eslint support (.eslintrc.js and npm run lint)
  • modernizes the codebase (type imports, override/declare modifiers, etc.)
  • reduces the number of any type occurrence and unnecessary casts
  • fixes all lint errors and type errors introduced by other changes
  • upgrades to bokeh 3.4 (specifically deals with ColumnarDataSource.data)

I suppose this supersedes PR #714 to some extent.

@hoxbro
Copy link
Member

hoxbro commented Mar 27, 2024

If you ever want more help with BokehJS, you need to stop doing these kinds of stunts.

I kindly asked you yesterday if you could help me with GeoViews in a 5-10 minute meeting. You have now done all of it by yourself, stopping what could have been a good learning experience for me with BokehJS.

@hoxbro hoxbro enabled auto-merge (squash) March 27, 2024 13:41
@hoxbro hoxbro merged commit 6d71fa5 into main Mar 27, 2024
9 checks passed
@hoxbro hoxbro deleted the mattpap/modernize_codebase branch March 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants