Update build CI #713
Update build CI #713
Conversation
|
|
||
| build: | ||
| noarch: python | ||
| script: python setup.py install --single-version-externally-managed --record=record.txt | ||
| script: {{ PYTHON }} -m pip install -vv {{ sdata['name'] }}-{{ VERSION }}-py3-none-any.whl |
There was a problem hiding this comment.
I'm curious, is that the standard approach for building a conda package, i.e. first run python -m build ... and then conda build ..., with the script set up to point to the wheel?
There was a problem hiding this comment.
From a purist standpoint, it is not the correct way of doing it. You won't see it used on defaults or conda-forge as they want to build it from the bottom.
From a maintainer standpoint, in my mind, it is so much easier to use the wheel and keep them separated. If a wheel can be built, then creating the conda package will not have a package-built problem. There could still be other problems with the conda-build, but that's at least one less hurdle to debug when things go wrong.
There was a problem hiding this comment.
Ok I see thanks. It's what Bokeh does too apparently, except they run it with --no-deps. Not sure what's the best practice there.
There was a problem hiding this comment.
I don't have any objections to adding --no-deps. You are welcome to add it.
Update build CI so it does not depend on pyctdev, split the build and publish up.