Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed precedence from parameter definitions in dashboard #707

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

jlstevens
Copy link
Collaborator

This PR removes the precedence settings of the parameters used in the dashboard. Once holoviz/panel#238 is merged, this definition order will automatically be respected (at least for Python 3.6+ - earlier versions will be sorted alphanumerically).

@jlstevens
Copy link
Collaborator Author

@jbednar Would this be a good reason to pin panel to the most recent version (assuming that panel PR is merged and is released?)

@jbednar
Copy link
Member

jbednar commented Feb 12, 2019

We'll probably need to pin for the other upcoming changes to param and panel, but for now it's not crucial.

@jlstevens
Copy link
Collaborator Author

Just to note that holoviz/panel#238 has been merged....

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now that precedence isn't being set as the first argument, the default value can be supplied as a positional argument, making it simpler.

examples/dashboard.ipynb Outdated Show resolved Hide resolved
examples/dashboard.ipynb Outdated Show resolved Hide resolved
examples/dashboard.ipynb Outdated Show resolved Hide resolved
examples/dashboard.ipynb Outdated Show resolved Hide resolved
Co-Authored-By: jlstevens <[email protected]>
@jbednar jbednar merged commit 26894b9 into master Feb 19, 2019
@jbednar jbednar deleted the dashboard_remove_precedence branch February 19, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants